Test local css import in production#43
Open
m-mujica wants to merge 2 commits into
Open
Conversation
m-mujica
commented
Apr 24, 2017
| var s = getComputedStyle(p); | ||
|
|
||
| if (window.assert) { | ||
| assert.equal(s.fontSize, "30px", "should inline the @import"); |
Contributor
Author
There was a problem hiding this comment.
need to update this text, we are no longer inlining the import, but since clean-css does no longer removes them. It should still work.
Contributor
Author
|
Update: the test should pass now since steal@1.3.2 fixes the issue with local css imports being removed from the css bundle. |
added 2 commits
June 27, 2017 14:43
- Update steal and steal-tools: steal-tools@1.3.2 includes the fix to make the local css @import test pass. - Update test assertion text: Local css imports are not inlined in production but they should still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm expecting this test to fail
Related to stealjs/steal-tools#673
Once that PR gets in I'll run this tests against steal-tools#master to make sure everything looks fine.